[PATCH] LLVM 2.8 fixes

[Daniel Dunbar]

On Thu, Aug 5, 2010 at 8:39 AM, Peter Collingbourne <pcc03 at doc.ic.ac.uk> wrote:
> Hi Daniel,
>
> On Thu, Aug 05, 2010 at 03:54:44PM +0100, Daniel Dunbar wrote:
>> The patches look good, the only thing I am worried about is whether
>> they also work with LLVM 2.6 and LLVM 2.7 -- have you checked those
>> configurations?
>
> I ran "make check" with 2.7 before I sent the patches out --
> no unexpected failures.  I have now also done the same with 2.6,
> same result.

Great, thanks!

> I'll commit this unless there is an objection.

Sure, please do.

I'm ambivalent about the 0001- change, though, although it is fine to
put it in. It isn't really a complete solution -- technically we would
need to have the test be based on the LLVM version, and then set or
unset DISABLE_ASSERTIONS as appropriate. Of course, then that is very
confusing because users then need to be aware of the change when
configuring KLEE.

Now that we have some support for optimized debug info in KLEE, I'm
beginning to think we should just eliminate the configure option for
which mode to build the runtime library in. It is too complicated and
annoying to deal with. Do you have an opinion on this?

 - Daniel

> Thanks,
> --
> Peter
>